Sebastian Huber commented on a discussion on 
testsuites/psxtests/psxtimes01/init.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/670#note_129072

 >  rtems_task Init(rtems_task_argument argument);
 >  clock_t _times_r(struct _reent *ptr, struct tms  *ptms);
 >  clock_t _times(struct tms  *ptms);
 > +void test_times_functions(void);

Globally visible functions should have exactly one declaration in a header 
file. To help finding functions for which this is not the case, the 
`-Wimplicit-function-declaration` is useful. In some tests, function 
declarations were added to silence this warning. However, these functions 
should have simply be made static instead. In this case, you can just write the 
function without a declaration. This produces less code.

For static functions, you normally don't need a separate declaration.

-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/670#note_129072
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to