Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/467 
was reviewed by Joel Sherrill

--
  
Joel Sherrill commented on a discussion on 
bsps/arm/altera-cyclone-v/contrib/hwlib/src/hwmgr/alt_dma.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/467#note_125472

 >  /////
 >  
 > -static bool alt_dma_is_init(void)

Static added back.

--
  
Joel Sherrill commented on a discussion on 
bsps/arm/altera-cyclone-v/contrib/hwlib/src/hwmgr/alt_clock_manager.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/467#note_125473

 > +#ifdef __rtems__
 > +static
 > +#endif

Whether or not they should, they have it now.

--
  
Joel Sherrill commented on a discussion on 
bsps/arm/altera-cyclone-v/contrib/hwlib/src/hwmgr/alt_clock_manager.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/467#note_125474

 >  //
 > +#ifndef __rtems__
 > +/* RTEMS: Needs a prototype if used */

Comment is now inside an #ifdef __rtems__ for future me.


-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/467
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to