Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/504 was reviewed by Gedare Bloom
-- Gedare Bloom started a new discussion on cpukit/include/rtems/imfs.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/504#note_125242 > struct IMFS_jnode_tt; > typedef struct IMFS_jnode_tt IMFS_jnode_t; > - avoid random whitespace changes -- Gedare Bloom started a new discussion on cpukit/include/rtems/imfs.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/504#note_125243 > const char *target > ); > +/** usually a blank line here -- Gedare Bloom started a new discussion on cpukit/libfs/src/imfs/imfs_rmnod.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/504#note_125244 > rv = -1; > } > + IMFS_fs_info_t *fs_info = loc->mt_entry->fs_info; declare variables at the start of their scope/block, or the start of the function -- Gedare Bloom started a new discussion on cpukit/libfs/src/imfs/imfs_rmnod.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/504#note_125245 > rv = -1; > } > + IMFS_fs_info_t *fs_info = loc->mt_entry->fs_info; is it certain to succeed, or need to check for errors/NULL? -- Gedare Bloom started a new discussion on cpukit/libfs/src/imfs/imfs_statvfs.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/504#note_125246 > + */ > + > +#include<rtems/imfsimpl.h> space -- Gedare Bloom started a new discussion on testsuites/psxtests/psximfs01/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/504#note_125247 > #include <rtems/libcsupport.h> > - > +#define CONFIGURE_BLOCK_SIZE 16 I would not call this `CONFIGURE_...` that is typically "reserved" for RTEMS confdefs system use. -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/504 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list bugs@rtems.org http://lists.rtems.org/mailman/listinfo/bugs
