Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/447 was reviewed by Gedare Bloom
-- Gedare Bloom started a new discussion on bsps/sparc/erc32/console/erc32_console.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/447#note_125232 > + ); > + > + ERC32_Clear_and_unmask_interrupt(CONSOLE_UART_A_TRAP); This is a pretty minor thing, but it might be better to do all the clearing and unmasking at the end. This is usually a safer way to write interrupt setup code. The alternative would be to put them all together, which keeps the code more similar to what was implemented before, in other words you would have: ``` rtems_interrupt_entry_initialize(); rtems_interrupt_entry_install(); ERC32_Clear_and_unmask_interrupt(); /* repeated 2 more times */ ``` -- Gedare Bloom started a new discussion on bsps/sparc/erc32/start/erc32trap.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/447#note_125233 > + * Copyright (c) 2025 Sunil Hegde <sunil1he...@gmail.com> > + * > + * only 1 blank line in a row -- Gedare Bloom started a new discussion on bsps/sparc/shared/start/leontrap.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/447#note_125234 > + LEON_Clear_interrupt(source); > + LEON_Unmask_interrupt(source); > + } I think we can make this shared across all the sparc bsps, by using the `BSP_Unmask_interrupt` and `BSP_Clear_interrupt` macros. Then, we can just make this something more like `SPARC_Clear_and_unmask_interrupt()` -- Gedare Bloom started a new discussion on bsps/sparc/shared/gnatcommon.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/447#note_125235 > + rtems_interrupt_catch (__gnat_interrupt_handler, trap, > &previous_isr_a); > + } > + } this formatting looks awful, we should probably clean it up now. -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/447 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list bugs@rtems.org http://lists.rtems.org/mailman/listinfo/bugs
