Merge request 
https://gitlab.rtems.org/rtems/tools/rtems-source-builder/-/merge_requests/154 
was reviewed by Joel Sherrill

--
  
Joel Sherrill started a new discussion on 
rtems/patches/0001-libc-Add-Update-prototypes-For-posix-issue8-function.patch: 
https://gitlab.rtems.org/rtems/tools/rtems-source-builder/-/merge_requests/154#note_124611

 > + #endif /* _POSIX_TIMEOUTS */
 > + 
 > +-#if __GNU_VISIBLE

This should be (__GNU_VISIBLE || __POSIX_VISIBLE >= 202405). As written it is 
&& not ||. I suspect this is repeated.

--
  
Joel Sherrill started a new discussion on 
rtems/patches/0001-libc-Add-Update-prototypes-For-posix-issue8-function.patch: 
https://gitlab.rtems.org/rtems/tools/rtems-source-builder/-/merge_requests/154#note_124612

 > + int pthread_mutex_clocklock(pthread_mutex_t *__restrict, clockid_t,
 > +                               const struct timespec *__restrict);
 > +-#endif /* __GNU_VISIBLE */

Again.

--
  
Joel Sherrill started a new discussion on 
rtems/patches/0001-libc-Add-Update-prototypes-For-posix-issue8-function.patch: 
https://gitlab.rtems.org/rtems/tools/rtems-source-builder/-/merge_requests/154#note_124613

 > +                            const struct timespec *__abstime);
 > + 
 > +-#if __GNU_VISIBLE

Again

--
  
Joel Sherrill started a new discussion on 
rtems/patches/0001-libc-Add-Update-prototypes-For-posix-issue8-function.patch: 
https://gitlab.rtems.org/rtems/tools/rtems-source-builder/-/merge_requests/154#note_124614

 > +                                const struct timespec *__abstime);
 > + 
 > +-#if __GNU_VISIBLE

Again

--
  
Joel Sherrill started a new discussion on 
rtems/patches/0001-libc-Add-Update-prototypes-For-posix-issue8-function.patch: 
https://gitlab.rtems.org/rtems/tools/rtems-source-builder/-/merge_requests/154#note_124615

 > ++
 > ++#if __POSIX_VISIBLE >= 202405
 > ++/* The posix Issue 8 standard adds sem_clockwait()*/

This comment isn't needed. Delete it.


-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/tools/rtems-source-builder/-/merge_requests/154
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to