Merge request https://gitlab.rtems.org/rtems/pkg/rtems-net-services/-/merge_requests/28 was reviewed by Gedare Bloom
-- Gedare Bloom started a new discussion on bsd/freebsd/contrib/ntp/ntpd/ntp_io.c: https://gitlab.rtems.org/rtems/pkg/rtems-net-services/-/merge_requests/28#note_122733 > +#include <rtems/ntpd.h> > +#endif /* __rtems__ */ > + remove the unguarded whitespace change -- Gedare Bloom started a new discussion on bsd/freebsd/contrib/ntp/ntpd/ntp_io.c: https://gitlab.rtems.org/rtems/pkg/rtems-net-services/-/merge_requests/28#note_122734 > > -#ifdef __rtems__ > wildif->fd = open_socket(&wildif->sin, 0, 0, wildif); This is keeping the rtems side and discarding the freebsd side. This is incorrect. if the line with arguments `0, 0` is needed, it should be kept inside the __rtems__ guard. -- Gedare Bloom started a new discussion on bsd/freebsd/contrib/ntp/ntpd/ntp_io.c: https://gitlab.rtems.org/rtems/pkg/rtems-net-services/-/merge_requests/28#note_122735 > -#else > wildif->fd = open_socket(&wildif->sin, 0, 1, wildif); > -#endif as contrasted to this one, which is doing the correct thing because it keeps the freebsd side and discards the rtems side. -- Gedare Bloom started a new discussion on bsd/rtemsbsd/include/rtems/ntpd.h: https://gitlab.rtems.org/rtems/pkg/rtems-net-services/-/merge_requests/28#note_122736 > + > +/** > + * @brief Lock the NTPD lock? remove the `?`? -- Gedare Bloom started a new discussion on bsd/rtemsbsd/include/rtems/ntpd.h: https://gitlab.rtems.org/rtems/pkg/rtems-net-services/-/merge_requests/28#note_122737 > + > +/** > + * @brief Unlock the NTPD lock? ditto -- View it on GitLab: https://gitlab.rtems.org/rtems/pkg/rtems-net-services/-/merge_requests/28 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list bugs@rtems.org http://lists.rtems.org/mailman/listinfo/bugs
