Shaunak Datar commented on a discussion on 
bsps/aarch64/raspberrypi/i2c/raspberrypi-i2c.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/363#note_121835

 > +
 > +static int rpi_i2c_transfer(i2c_bus *base, i2c_msg *msgs, uint32_t 
 > msg_count)
 > +{
 > +    raspberrypi_i2c_bus *bus = (raspberrypi_i2c_bus *)base;
 > +    int rv = 0;
 > +    uint32_t i;
 > +
 > +    for (i = 0; i < msg_count; ++i)
 > +    {
 > +        if (msgs[i].flags & I2C_M_RECV_LEN)
 > +        {
 > +            return RTEMS_INVALID_NUMBER;
 > +        }
 > +    }
 > +
 > +    for (i = 0; i < msg_count; i++)

Technically the loops can be merged but because one does validation of the 
input and the other does the actual processing, they have been kept separate. 
Do you want me to merge them?

-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/363#note_121835
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs
        • ... Shaunak Datar (@skdatar)
  • Re: RTEMS ... Gedare Bloom (@gedare)
    • Re: R... Shaunak Datar (@skdatar)
      • R... Kinsey Moore (@opticron)
  • Re: RTEMS ... Gedare Bloom (@gedare)
    • Re: R... Shaunak Datar (@skdatar)
      • R... Gedare Bloom (@gedare)
        • ... Kinsey Moore (@opticron)
  • Re: RTEMS ... i2c_support (@project_255_bot_00584f716a643d95007bea79bc8c5f97)
  • Re: RTEMS ... Gedare Bloom (@gedare)
    • Re: R... Shaunak Datar (@skdatar)
      • R... Gedare Bloom (@gedare)
        • ... Shaunak Datar (@skdatar)
          • ... Gedare Bloom (@gedare)
            • ... Shaunak Datar (@skdatar)
  • Re: RTEMS ... i2c_support (@project_255_bot_00584f716a643d95007bea79bc8c5f97)
  • Re: RTEMS ... Shaunak Datar (@skdatar)
  • Re: RTEMS ... i2c_support (@project_255_bot_00584f716a643d95007bea79bc8c5f97)
  • Re: RTEMS ... i2c_support (@project_255_bot_00584f716a643d95007bea79bc8c5f97)
  • Re: RTEMS ... Shaunak Datar (@skdatar)

Reply via email to