Shaunak Datar commented on a discussion on 
bsps/aarch64/raspberrypi/i2c/raspberrypi-i2c.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/363#note_121525

 > +    while(bus->remaining_transfers > 0){
 >          bus->remaining_bytes = bus->remaining_transfers > 1 ? 0xFFFF : 
 > (bus->current_buffer_size & 0xFFFF);
 > -        BCM2835_REG(bus->base_address + BCM2711_I2C_DLEN) = 
 > bus->remaining_bytes;
 > -        BCM2835_REG(bus->base_address + BCM2711_I2C_STATUS) |= (3 << 8);
 > -        BCM2835_REG(bus->base_address + BCM2711_I2C_CONTROL) |= (1 << 7);
 > -        if ((BCM2835_REG(bus->base_address + BCM2711_I2C_STATUS) & (1 << 
 > 8)) != 0)
 > -        {
 > -            return -EIO;
 > -        }
 > -
 > +        BCM2835_REG(bus->base_address + BCM2711_I2C_DLEN) = 
 > bus->remaining_bytes;    
 > +        BCM2835_REG(bus->base_address + BCM2711_I2C_STATUS) = S_ERR | 
 > S_CLKT | S_DONE;
 > +        
 >          rv = rpi_i2c_bus_transfer(bus);
 > -
 > +        

here I have changed it to use macros to add readability

-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/363#note_121525
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs
          • ... Shaunak Datar (@skdatar)
            • ... Kinsey Moore (@opticron)
              • ... Shaunak Datar (@skdatar)
              • ... Kinsey Moore (@opticron)
              • ... Shaunak Datar (@skdatar)
              • ... Kinsey Moore (@opticron)
              • ... Shaunak Datar (@skdatar)
              • ... Shaunak Datar (@skdatar)
    • Re: R... Shaunak Datar (@skdatar)
      • R... Shaunak Datar (@skdatar)
    • Re: R... Shaunak Datar (@skdatar)
  • Re: RTEMS ... Gedare Bloom (@gedare)
  • Re: RTEMS ... i2c_support (@project_255_bot_00584f716a643d95007bea79bc8c5f97)
  • Re: RTEMS ... Shaunak Datar (@skdatar)
  • Re: RTEMS ... Kinsey Moore (@opticron)
  • Re: RTEMS ... Kinsey Moore (@opticron)
  • Re: RTEMS ... i2c_support (@project_255_bot_00584f716a643d95007bea79bc8c5f97)
  • Re: RTEMS ... i2c_support (@project_255_bot_00584f716a643d95007bea79bc8c5f97)
  • Re: RTEMS ... Shaunak Datar (@skdatar)

Reply via email to