Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/443 was reviewed by Gedare Bloom
-- Gedare Bloom started a new discussion on cpukit/rtems/src/barriergetnumwaiting.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/443#note_120656 > + */ > + > + #ifdef HAVE_CONFIG_H there's an extra `' '` at the start of every line, from here to the end of the file. You can also get a hint about this from the pipeline warnings from format stage. -- Gedare Bloom started a new discussion on testsuites/sptests/sp33/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/443#note_120657 > > + /* Get number waiting with bad return pointer */ > + puts( "rtems_barrier_get_number_waiting - NULL return count - > INVALID_ADDRESS" ); This line is overlength, break it either by putting the string on its own line, shorten the string if possible, or split the string into two strings. -- Gedare Bloom started a new discussion on testsuites/sptests/sp33/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/443#note_120658 > + status = rtems_barrier_get_number_waiting( Barrier, &waiting ); > + directive_failed(status, "rtems_barrier_get_number_waiting"); > + if ( waiting != (CONFIGURE_MAXIMUM_TASKS-1) ) { we also want space characters in the nested parens, and around all binary operators, so `( CONFIGURE_MAXIMUM_TASKS - 1 )` -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/443 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list bugs@rtems.org http://lists.rtems.org/mailman/listinfo/bugs
