Merge request https://gitlab.rtems.org/rtems/docs/rtems-docs/-/merge_requests/146 was reviewed by Chris Johns
-- Chris Johns started a new discussion on eng/coding-formatting.rst: https://gitlab.rtems.org/rtems/docs/rtems-docs/-/merge_requests/146#note_119297 > > +* Minimize reformatting existing code in RTEMS unless the file undergoes > + substantial non-style changes. And if the file is one of a number in the same area of code. There is no point changing a file in a set unless the whole set of files is changed. -- Chris Johns started a new discussion on eng/coding-conventions.rst: https://gitlab.rtems.org/rtems/docs/rtems-docs/-/merge_requests/146#note_119298 > + #if defined(__rtems__) > + /* changes made */ > + #endif Should this be: ``` #endif /* __rtems__ */ ``` -- Chris Johns started a new discussion on eng/coding-conventions.rst: https://gitlab.rtems.org/rtems/docs/rtems-docs/-/merge_requests/146#note_119299 > + #ifdef FEATURE_X > + /* Do something */ > + #else Comments to help isolate which define the `#else` and `#endif` is linked to the define? -- View it on GitLab: https://gitlab.rtems.org/rtems/docs/rtems-docs/-/merge_requests/146 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list bugs@rtems.org http://lists.rtems.org/mailman/listinfo/bugs
