Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/294 
was reviewed by Joel Sherrill

--
  
Joel Sherrill started a new discussion on bsps/arm/stm32h7/dma/dma-allocator.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/294#note_114414

 > +{
 > +  switch (base) {
 > +  case DMA1_Stream0_BASE:

Is there any chance one of the constants can be 0? This would conflict with the 
return 0 at the bottom.

--
  
Joel Sherrill started a new discussion on bsps/arm/stm32h7/spi/spi-support.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/294#note_114415

 > +  }
 > +#endif
 > +  if (ctx->spi.hdmatx == NULL) {

Blank line between the #endif and the if.


-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/294
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to