Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/227 
was reviewed by Chris Johns

--
  
Chris Johns started a new discussion on cpukit/score/src/percpustatewait.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/227#note_112393

 > +#include <rtems/score/smpimpl.h>
 > +
 > +bool _Per_CPU_Wait_for_non_initial_state( uint32_t cpu_index )

Why return anything when it is always `true` given the commit changes 
functionality by removing the timeout?

--
  
Chris Johns started a new discussion on cpukit/score/src/smp.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/227#note_112394

 > +    if ( cpu != cpu_self ) {
 >        if ( _Scheduler_Should_start_processor( assignment ) ) {
 >          started = _CPU_SMP_Start_processor( cpu_index );

This is an interface that accepts a `bool` result of the CPU starting but this 
change removes that logic from the arm BSPs. Do any of the SMP supportted arch 
detect a CPU failing to start?


-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/227
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to