Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/230 was reviewed by Chris Johns
-- Chris Johns started a new discussion on bsps/arm/xilinx-zynqmp-rpu/include/bsp/irq.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/230#note_112263 > - * and Josh Whitehead <josh.whiteh...@dornerworks.com> > + * Copyright (C) 2024 embedded brains GmbH & Co. KG > + * Copyright (C) 2023 Reflex Aerospace GmbH I do not understand this change? Maybe add some details on why this fixes the copyright to the commit message? -- Chris Johns started a new discussion on bsps/arm/xilinx-zynqmp-rpu/start/bspreset.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/230#note_112264 > - /* Wait */ > + /* Request a soft system reset */ > + *reset_ctrl |= UINT32_C(0x10); Would this reset the APU? If so this is not a good idea and something else will need to be figured out. -- Chris Johns started a new discussion on spec/build/bsps/arm/xilinx-zynqmp-rpu/linkcmds.yml: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/230#note_112265 > + *(SORT(.ocm*)); > + } > OCM AT > OCM > + } Please add a comment that Xilinx defaults to using OCM for u-boot and ATF and using it on the RPU could conflict with that. -- Chris Johns started a new discussion on bsps/shared/dev/irq/arm-gicv2.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/230#note_112266 > > -#ifdef RTEMS_SMP > +#if defined(BSP_IRQ_HAVE_GET_SET_AFFINITY) Does this effect other BSPs which use this code? -- Chris Johns started a new discussion on cpukit/score/cpu/arm/include/rtems/score/cpu.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/230#note_112267 > + }; > + > + uint32_t registers[ 16 ]; Interesting solution and I like it. Is this standard C code or a gcc extension? -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/230 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list bugs@rtems.org http://lists.rtems.org/mailman/listinfo/bugs
