shuhua hua commented on a discussion: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/202#note_111838


Sure, I'll pay attention to my code style. I reviewed the 
testsuites/libtests/shell01/init.c test case you mentioned, and I think there 
might have been a misunderstanding. My submission concerns an issue I 
encountered while using the shell: when it prompts me for a username, other 
programs subsequently print some logs. At that point, I press Enter intending 
to clear these logs and expecting the username prompt to reappear. However, the 
system unexpectedly jumps to requesting a password, which prompted me to submit 
that pull request.

Regarding init.c that you just mentioned, I attempted to add two test cases 
within it:

1.When rtems_shell_login_check("", NULL) is tested, the return value of false 
is understandable. 

2.However, when I test rtems_shell_login_check(NULL, NULL), the return value is 
true. Is this return value expected behavior?

-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/202#note_111838
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to