Ning Yang commented on a discussion on bsps/shared/dev/serial/arm-pl011.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/47#note_111525 > + > + /* Control: Re-enable UART */ > + cr |= PL011_UARTCR_UARTEN | PL011_UARTCR_TXE; > + > + return cr; > +} > + > +static bool arm_pl011_set_attributes( > + rtems_termios_device_context *base, > + const struct termios *term > +) > +{ > + uint32_t ibrd, fbrd, lcrh, baud, cr; > + int err; > + arm_pl011_context *context = (arm_pl011_context *) base; > + arm_pl011_uart *regs = arm_pl011_get_regs(base); If I add `volatile` in this line, the parameters of functions `arm_pl011_enable_irq` and `arm_pl011_clear_irq` must also be added volatile(Otherwise the compiler will issue a warning), which is unnecessary. Add `volatile` to them all? -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/47#note_111525 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list bugs@rtems.org http://lists.rtems.org/mailman/listinfo/bugs
