Kinsey Moore started a new discussion on 
bsps/aarch64/xilinx-versal/include/dev/serial/versal-uart.h: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/47#note_109912

 >   */
 >  
 >  typedef struct {
 > -  rtems_termios_device_context base;
 > -  volatile struct versal_uart *regs;
 > -  volatile size_t tx_queued;
 > +  pl011_base base;
 > +} versal_uart;

If I recall correctly, the reason to wrap the pl011 registers with a unique 
Versal struct was because there were additional registers beyond the base 
register set on some implementations, but I don't see those here. Did they get 
accidentally left out? If not, this does not need to be wrapped.

-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/47#note_109912
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to