Merge request 
https://gitlab.rtems.org/rtems/tools/rtems-source-builder/-/merge_requests/35 
was reviewed by Christian Mauderer

--
  
Christian Mauderer started a new discussion on rtems/config/stdcxx-template.py: 
https://gitlab.rtems.org/rtems/tools/rtems-source-builder/-/merge_requests/35#note_109044

 > +import sys

Is that file copied from somewhere or did you write it yourself? Depending on 
that: Please add a standard RTEMS license header (or rather the one from the 
RSB LICENSE file) to it if you wrote it yourself or use the original license if 
you copied it from somewhere.

--
  
Christian Mauderer started a new discussion on rtems/config/stdcxx-template.py: 
https://gitlab.rtems.org/rtems/tools/rtems-source-builder/-/merge_requests/35#note_109045

 > +gcc_path = os.path.dirname(os.path.dirname(gdb_path))
 > +gcc_path = os.path.join(gcc_path, "gcc-" + gcc_version)
 > +gcc_python_path = os.path.join(gcc_path, "python")

Just to understand these lines:

* `gdb_path` is something like `${PREFIX}/share/gdb/python`, right?
* Then your `gcc_python_path` is something like 
`${PREFIX}/share/gcc-13.2.1/python`, right?

--
  
Christian Mauderer started a new discussion on 
source-builder/config/gcc-common-1.cfg: 
https://gitlab.rtems.org/rtems/tools/rtems-source-builder/-/merge_requests/35#note_109046

 > +
 > +  # Get the current GCC version of the target being built. 
 > +  %define rsb_rtems_gcc_version %(%{_bindir}/%{_target}-gcc --version | 
 > head -1 | awk '{print $3}')

Shouldn't we have a %{gcc_version} already? @chris: You know the source builder 
a lot better.




-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/tools/rtems-source-builder/-/merge_requests/35
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to