On 24 Jan 2019 08:19:00 -0700, "Andy Bradford" wrote: > The problem is caused by the way that offset is derived for the special > handling of Friday. If the day in the date is a Friday, offset is set to > 3 so that events happening on the weekend are printed. In the case you > presented, you set -t 20190109 which does not land on a Friday, but the > way the code currently works it takes your -B 33 and sets the date to > 20181207 which *is* a Friday. Now offset is set to 3 and it makes your > -B 33 extend the 20181207 all the way to 20190112 which matches your 12 > January calendar entry. > > It looks like currently if -A is used the Friday handling is disabled, > so the following patch also disables it when -B is used.
I think that's the correct approach. > Alternatively, the question arises, should Friday handling be disabled > when -A or -B are used? Yes, I think so. Otherwise it looks to the user like the number of days specified by -A or -B is not being handled correctly. > Question for the list: given that this is my first time posting on bugs@ > I'm not sure if patches are expected here or on tech@ when addressing > bugs. Guidance appreciated if necessary. Patches are always welcome on bugs@ and this one looks good to me. - todd
