On Wed, Apr 18, 2018 at 10:27:44PM +1000, Jonathan Matthew wrote:
> On Sat, Apr 14, 2018 at 06:54:35AM +0200, [email protected] wrote:
> > >Synopsis: page fault trap when removing urtwn Wifi adapter from the port
> > >Category: kernel
> > >Environment:
> > System : OpenBSD 6.3
> > Details : OpenBSD 6.3 (GENERIC.MP) #107: Sat Mar 24 14:21:59 MDT
> > 2018
> >
> > [email protected]:/usr/src/sys/arch/amd64/compile/GENERIC.MP
> >
> > Architecture: OpenBSD.amd64
> > Machine : amd64
> > >Description:
> > I'm observing system crash if I remove the the TP-Link TL-WN725N
> > WiFi adapter from the port. The system reports kernel panic:
> >
> > kernel: page fault trap, code=0
> > Stopped at softclock+0x16b: movq %rax,0(%rdx)
>
> Does this fix it?
Either way, OK with me.
It occurred to me we might not want to schedule this timeout in the
first place if the driver doesn't support background scan.
I'll take a look at that next week.
> Index: ieee80211.c
> ===================================================================
> RCS file: /cvs/src/sys/net80211/ieee80211.c,v
> retrieving revision 1.65
> diff -u -p -u -p -r1.65 ieee80211.c
> --- ieee80211.c 12 Dec 2017 15:52:49 -0000 1.65
> +++ ieee80211.c 18 Apr 2018 12:25:34 -0000
> @@ -193,6 +193,7 @@ ieee80211_ifdetach(struct ifnet *ifp)
> {
> struct ieee80211com *ic = (void *)ifp;
>
> + timeout_del(&ic->ic_bgscan_timeout);
> ieee80211_proto_detach(ifp);
> ieee80211_crypto_detach(ifp);
> ieee80211_node_detach(ifp);
>
>