On Thu, Sep 21, 2023 at 06:24:01PM +0200, Patrice Dumas wrote: > Hello, > > On Wed, Sep 20, 2023 at 08:44:34PM +0100, Gavin Smith wrote: > > Perhaps we should keep on resetting CFLAGS and LDFLAGS (in line with > > the autoconf manual), but leave CPPFLAGS alone due to gnulib's special > > use of it. > > Since we need to avoid resetting CPPFLAGS to get the libunistring flags, > we should use CFLAGS to put CPPFLAGS we want to test gnulib with in > configure.ac -- which is not unlike what is already done. > > In any case both your analysis and solution looks right to me. Here is > a simple patch proposal.
I've committed this in your name. The other problems with configure.ac/Makefile.am consistency appear valid and something we should fix, but I'd like to leave it until after the release as these have not led to any reported problems.
