On Tue, Oct 12, 2021 at 07:16:06PM -0500, Jacob Bachmeyer wrote: > Patrice Dumas wrote: > > On Mon, Oct 11, 2021 at 11:25:13PM -0500, Jacob Bachmeyer wrote: > > > Patrice Dumas wrote: > > > > Actually it was probably simply an oversight. Note that I have kept the > > > > function names in other warning messages, as either it is useful to have > > > > the function name as the user should have used the function or the > > > > message should not actually happen, it is more like a bug. I am not > > > > 100% sure on the second case, but these messages are not supposed to > > > > happen in normal cases. > > > What about making the message unique? "unknown variable set on command > > > line: > > > OPEN_CODE_QUOTE"? > > > > I used "unknown variable from command line: OPEN_CODE_QUOTE". I am not > > an english native speaker, though. Should I replace with "unknown > > variable set on command line"? > > Both make sense. Other options include: "command line sets unknown variable: > %s" and "option sets unknown variable: %s" > > I think the best advice I could give here would be to make it consistent > with other errors occurring as a result of unrecognized options on the > command line.
Then it's ok, as there are other messages starting with "unknwown ..." -- Pat
