On 04/22/2016 03:53 PM, Chet Ramey wrote: > On 4/22/16 10:24 AM, Pedro Alves wrote: > >>> All of the public symbols in history.h are part of the history library, >>> which can be built both as part of readline and separately. We were a >>> little careless 25 years ago with the public function names, and it's too >>> late to change those now, but all of the history library variables have a >>> `history_' prefix. >> >> Note that "history_offset" is declared in histlib.h however, which reads: >> >> /* histlib.h -- internal definitions for the history library. */ >> ... >> /* Some variable definitions shared across history source files. */ >> extern int history_offset; > > That definition is in history.h in readline-7.0.
Ah. I started by looking at gdb's older readline copy, but I was actually looking at the "devel" branch before sending that. In there, we indeed have: history.h:extern int history_offset; But we also still have: histlib.h:extern int history_offset; misc.c:extern int history_offset; examples/hist_purgecmd.c:44:extern int history_offset; examples/hist_erasedups.c:41:extern int history_offset; which was what misled me. Shouldn't all these extern declarations except the history.h one be removed? Thanks, Pedro Alves _______________________________________________ Bug-readline mailing list [email protected] https://lists.gnu.org/mailman/listinfo/bug-readline
