On Sun, 2016-04-24 at 10:01 +0300, Eli Zaretskii wrote: > Isn't it also true that the ABI for loaded modules has changed in this > version? I see that the gmk_floc object now has a new member > 'offset'. Should this be called out in NEWS?
You're right. I reverted this change (or rather, I modified things so that the gmk_floc type is the same as it was before and is only used by the loadable object API, and that the rest of make uses a different type which has the extra member). I feel that there's no need to have the offset member visible through the loadable object API. > If the new ABI is incompatible with the old one, we should bump the > number of the import library we produce for MS-Windows, so it will now > be libgnumake-2.dll. Is there any concept of "compatible ABI" with DLLs in Windows? Sort of like the UNIX major and minor .so versions? > I needed a few changes in the test suite, to get it to reports as few > bogus failures as possible, as expected. Here are the most prominent > issues: I see that you didn't push any fixes for these issues. Do you plan to do that or should I look into it? If you don't want to push the changes as-is (maybe they work on Windows but are not portable) you can send me a diff of the changes you made and I can look at them. _______________________________________________ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make
