> From: Paul Smith <psm...@gnu.org> > Date: Thu, 14 Apr 2011 13:29:09 -0400 > > On Thu, 2011-04-14 at 11:01 -0400, David Boyce wrote: > > On Tue, Apr 12, 2011 at 1:46 PM, David Boyce <david.s.bo...@gmail.com> > > wrote: > > > So I've made a proof-of-concept patch > > > against 3.82.90 which seems to work without that overhead and my > > > question is, would this be of interest towards 3.83? > > > > Ping? > > > > The original patch attachment was made by hand using "diff -u" and I > > had some trouble applying it myself. So here's a version created with > > "cvs -q diff -uN" which should work better. > > I've looked at it and as a concept I don't have too many issues with it > (although I'd like to hear from the ports)
David, can you explain why you needed to lock the files? Also, what region(s) of the file you are locking? fcntl with F_WRLCK won't work on Windows, so the question is how to emulate it. Finally, I'd suggest that the system-dependent portions of sync_output be factored out into a separate function, so that the Windows port could have its own implementation without infesting job.c with yet another bunch of #ifdef's. TIA _______________________________________________ Bug-make mailing list Bug-make@gnu.org http://lists.gnu.org/mailman/listinfo/bug-make
