On Fri, Jul 9, 2010 at 2:14 PM, Eli Zaretskii <e...@gnu.org> wrote: >> From: Ozkan Sezer <invalid.nore...@gnu.org> >> Date: Mon, 05 Jul 2010 19:58:04 +0000 >> >> >> Follow-up Comment #11, bug #27809 (project make): >> >> On Mon, Jul 5, 2010 at 9:42 PM, Eli Zaretskii <e...@gnu.org> wrote: >> >> From: "Paul D. Smith" <invalid.nore...@gnu.org> >> >> Date: Mon, 05 Jul 2010 18:32:15 +0000 >> >> >> >> I've applied most of the second patch. The first patch is >> >> mostly in the w32 area so maybe Eli is a better person to >> >> review it? >> > >> > I will try to do that over the next few days. >> > >> >> A note on this: The second patch contained changes to main.c >> which are windows specific, used to fix the following win64 >> warnings: >> >> main.c: In function 'handle_runtime_exceptions': >> main.c:685: warning: cast from pointer to integer of different size >> main.c:693: warning: cast from pointer to integer of different size >> main.c:701: warning: format '%lx' expects type 'long unsigned int', but >> argument 3 has type 'ULONG_PTR' >> main.c:701: warning: format '%lx' expects type 'long unsigned int', but >> argument 3 has type 'ULONG_PTR' >> main.c:997: warning: suggest braces around empty body in an 'else' statement >> main.c:998: warning: suggest braces around empty body in an 'else' statement >> main.c:1402: warning: initialization discards qualifiers from pointer target >> type > > I fixed this by using %p, which is much more portable than %Id etc. > >> To make the reviewers' lives easier, I am attaching a combined >> all-in-one patch, w64-all-20100705.diff. This obsoletes all >> the other patches attached here. In addition, it also covers the >> tiny patch sugggested in bug #27825 too, so bug #27825 can be >> closed. > > Thanks. I used almost all of the patches in w64-all-20100705.diff. >
Thanks for applying the patches. There are some issues, though: * config.h.W32.template: Despite what the changelog says, it is not modified. * make.h: Missed update for w32_kill prototype, int w32_kill (pid_t pid, int sig); ... which makes the builds fail: job.c:250: error: conflicting types for 'w32_kill' make.h:329: note: previous declaration of 'w32_kill' was here * w32/subproc/sub_proc.c: Handles & pids still used with int types which really must be intptr_t types as suggested in the patch. See these warnings: w32/subproc/sub_proc.c: In function 'process_wait_for_any_private': w32/subproc/sub_proc.c:96: warning: cast to pointer from integer of different size w32/subproc/sub_proc.c: In function 'process_kill': w32/subproc/sub_proc.c:129: warning: cast to pointer from integer of different size w32/subproc/sub_proc.c: In function 'process_init': w32/subproc/sub_proc.c:313: warning: cast from pointer to integer of different size w32/subproc/sub_proc.c:314: warning: cast from pointer to integer of different size w32/subproc/sub_proc.c:315: warning: cast from pointer to integer of different size w32/subproc/sub_proc.c:316: warning: cast from pointer to integer of different size w32/subproc/sub_proc.c:317: warning: cast from pointer to integer of different size w32/subproc/sub_proc.c:318: warning: cast from pointer to integer of different size w32/subproc/sub_proc.c: In function 'process_init_fd': w32/subproc/sub_proc.c:340: warning: cast from pointer to integer of different size w32/subproc/sub_proc.c:341: warning: cast from pointer to integer of different size w32/subproc/sub_proc.c:342: warning: cast from pointer to integer of different size w32/subproc/sub_proc.c: In function 'process_begin': w32/subproc/sub_proc.c:545: warning: cast to pointer from integer of different size w32/subproc/sub_proc.c:546: warning: cast to pointer from integer of different size w32/subproc/sub_proc.c:547: warning: cast to pointer from integer of different size w32/subproc/sub_proc.c:578: warning: cast from pointer to integer of different size w32/subproc/sub_proc.c:583: warning: cast to pointer from integer of different size w32/subproc/sub_proc.c:584: warning: cast to pointer from integer of different size w32/subproc/sub_proc.c:585: warning: cast to pointer from integer of different size w32/subproc/sub_proc.c: In function 'proc_stdin_thread': w32/subproc/sub_proc.c:603: warning: cast to pointer from integer of different size w32/subproc/sub_proc.c: In function 'proc_stdout_thread': w32/subproc/sub_proc.c:630: warning: cast to pointer from integer of different size w32/subproc/sub_proc.c: In function 'proc_stderr_thread': w32/subproc/sub_proc.c:662: warning: cast to pointer from integer of different size w32/subproc/sub_proc.c: In function 'process_pipe_io': w32/subproc/sub_proc.c:699: warning: cast to pointer from integer of different size w32/subproc/sub_proc.c:716: warning: cast to pointer from integer of different size w32/subproc/sub_proc.c:781: warning: cast to pointer from integer of different size w32/subproc/sub_proc.c:789: warning: cast to pointer from integer of different size w32/subproc/sub_proc.c:797: warning: cast to pointer from integer of different size w32/subproc/sub_proc.c: In function 'process_file_io': w32/subproc/sub_proc.c:871: warning: cast to pointer from integer of different size w32/subproc/sub_proc.c:879: warning: cast to pointer from integer of different size w32/subproc/sub_proc.c:883: warning: cast to pointer from integer of different size w32/subproc/sub_proc.c:887: warning: cast to pointer from integer of different size w32/subproc/sub_proc.c: In function 'process_cleanup': w32/subproc/sub_proc.c:936: warning: cast to pointer from integer of different size w32/subproc/sub_proc.c:937: warning: cast to pointer from integer of different size w32/subproc/sub_proc.c:938: warning: cast to pointer from integer of different size w32/subproc/sub_proc.c:939: warning: cast to pointer from integer of different size w32/subproc/sub_proc.c:940: warning: cast to pointer from integer of different size w32/subproc/sub_proc.c:941: warning: cast to pointer from integer of different size w32/subproc/sub_proc.c:944: warning: cast to pointer from integer of different size w32/subproc/sub_proc.c:945: warning: cast to pointer from integer of different size > There's one issue -- with declaration of alloca -- that awaits Paul's > response, since I don't think we should include malloc.h. > This one: http://lists.gnu.org/archive/html/bug-make/2010-07/msg00054.html ... yes? I agree that if that part of make.h goes back to the state as it was in 3.81 then no problems. -- Ozkan _______________________________________________ Bug-make mailing list Bug-make@gnu.org http://lists.gnu.org/mailman/listinfo/bug-make
