On Mon, 2007-01-08 at 22:26 -0500, Ken Takusagawa wrote:
> In main.c we have
>
> jobserver_fds->list[0] = xmalloc ((sizeof ("1024")*2)+1);
>
> sprintf (jobserver_fds->list[0], "%d,%d", job_fds[0], job_fds[1]);
>
> Shouldn't xmalloc get a "+2" instead of "+1"? 1 for the comma, and
> one for the null terminator?
sizeof("1024") is 5 (the sizeof() a constant string includes the \0
terminator). I'm not sure why we add one, to be honest. Just being
extra safe I guess.
--
-------------------------------------------------------------------------------
Paul D. Smith <[EMAIL PROTECTED]> Find some GNU make tips at:
http://www.gnu.org http://make.paulandlesley.org
"Please remain calm...I may be mad, but I am a professional." --Mad Scientist
_______________________________________________
Bug-make mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/bug-make
