Hi, On Tue, Apr 14, 2026 at 07:43:30AM +0100, Michael Kelly wrote: > > 3) There is no need to alter the ibuf_write and msgbuf_write functions. > Simply defining IOV_MAX to something similar to that defined by Linux or > OpenBSD would work. It's true that the code here is not defensive in that if > the number of items in the msgbuf->bufs exceeds IOV_MAX then some buffers > won't be written.
It's not about the code but the system limits. Under Linux or OpenBSD this constant is defined. Not under GNU Hurd. > There is of course no actual limit for Hurd so something like > the following would suffice (suitably qualified perhaps for Hurd only): > > #ifndef IOV_MAX > #define IOV_MAX 1024 > #endif > It's easy to rely on a #define but that's probably not the right approach. Moreover when the usage of the limit constant is modularized clearly and the change surface is so little. https://www.gnu.org/software/hurd/hurd/porting/guidelines.html#PATH_MAX_tt_MAX_PATH_tt_MAXPATH Anyway, do as you guys see fit better. Cheers
