On 10/10/2025 07:37, Damien Zammit wrote:
This allows reading irq device status 0 for the mode of the interrupt
controller, pic or apic.
Thanks, Damien,
I've added code to hurd/acpi server to make use of this new feature to
set the ACPI pic mode. I've only tested this on 64 bit and with
--enable-apic but that combination is fine. Once I've tested on i386
with enable and disable ioapic I'll send out my patch for consideration.
I have 2 queries regarding your patch:
1) If I run my modified acpi server against an unmodified gnumach
kernel, there doesn't seem to be a way of detecting that your new
feature is absent. The old 'get_stat' for "irq" was nulldev_getstat()
which returns D_SUCCESS and an unmodified 'count'. I would have thought
that function would return either a failure result or at least a count
of zero? In any case, it doesn't help detect an old kernel. The actual
value returned for pic_mode in these circumstances was consistently 46
but I'm assuming that is a meaningless or uninitialised value.
2) It would be handy if the ACPI_PICMODE_xxxx defines were available on
the userland side but since the values are copied from standards it
hardly matters by duplicating them on the client side anyway.
Cheers,
Mike.
