On Sat, Sep 27, 2025 at 11:45:05PM +0200, Samuel Thibault wrote: > [email protected], le sam. 27 sept. 2025 21:50:33 +0100, a ecrit: > > @@ -519,7 +520,11 @@ store_nbd_open (const char *name, int flags, struct > > store **store) > > if (!strncmp (name, url_prefix, sizeof url_prefix - 1)) > > err = store_set_name (*store, name); > > else > > - asprintf (&(*store)->name, "%s%s", url_prefix, name); > > + { > > + int err; > > + err = asprintf (&(*store)->name, "%s%s", url_prefix, name); > > That will sooner or later warn that the previous `err` variable is being > shadowed. >
Maybe I should rename it to 'err2'? Or 'res'? Or the more verbose 'asprintf_result'? :P
