Hello,

Damien Zammit via Bug reports for the GNU Hurd, le jeu. 05 déc. 2024 04:32:51 
+0000, a ecrit:
> Fallthrough was incorrectly using fxsave() instead of
> xsave() or xsaveopt().
> 
> TESTED: on AMD fam15h: no longer throws "No coprocessor" exception.

We can as well just call fpu_save() here rather than repeating its
content, can't we?

Samuel

> ---
>  i386/i386/fpu.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/i386/i386/fpu.c b/i386/i386/fpu.c
> index 3d146f71..203de993 100644
> --- a/i386/i386/fpu.c
> +++ b/i386/i386/fpu.c
> @@ -285,7 +285,11 @@ fpu_module_init(void)
>               fp_default_state->xfp_save_state.header.xcomp_bv = 
> XSAVE_XCOMP_BV_COMPACT;
>               /* Fallthrough */
>           case FP_XSAVE:
> +             xsave(&fp_default_state->xfp_save_state);
> +             break;
>           case FP_XSAVEOPT:
> +             xsaveopt(&fp_default_state->xfp_save_state);
> +             break;
>           case FP_FXSAVE:
>               fxsave(&fp_default_state->xfp_save_state);
>               break;
> -- 
> 2.45.2
> 
> 
> 

-- 
Samuel
> No manual is ever necessary.
May I politely interject here: BULLSHIT.  That's the biggest Apple lie of all!
(Discussion in comp.os.linux.misc on the intuitiveness of interfaces.)

Reply via email to