On 11/8/24 4:48 PM, Sergey Bugaev wrote:
Hi Zhaoming,
Hi
On Fri, Nov 8, 2024 at 11:01 AM Samuel Thibault <samuel.thiba...@gnu.org> wrote:
Here as well this breaks the build since at this point of the series you
haven't added rtc.h yet. Better just merge all the patches.
To expand on what Samuel says, the point is that the repo is expected
to build successfully if you check out any specific Git commit. This
is helpful for using 'git bisect' in particular to catch regressions
[0], but is also generally a good practice. You might call it a part
of Git hygiene.
So not only are you expected to split your diff into a set of
reasonably-sized, self-sufficient, reviewable patches; you should also
consider the dependencies between your changes, and commit them in the
right order.
I didn't realise it. I will try to get used to it.
But for your case here, you can just squash the patches into one.
OK
--
Zhaoming Luo
