On Tue, 2017-09-26 at 22:07 +0200, Samuel Thibault wrote:
> Hello,
>
> This time it looks correct :)
>
> (just a couple of nitpicks which I'll just fix).
I saw that I forgot to free (cwd) immediately in execve.c. Do you want an
updated patch? Additionally I wrote in spawni.c:
/* Absolute path */
if (filename[0] == '/')
break;
/* Relative path */
else
{
...
break;
}
This could be written as
/* Relative path */
if (filename[0] != '/')
{
...
}
break;
I preferred the first version for clarity.
What else did you find? Just curious, since I did not find a commit yet.
