There is a code path when db_error() can return. Avoid, by writing returns, 
deleting the breakpoint when breakpoint number is not valid or there is no 
such breakpoint.

* ddb/db_break.c (db_delete_cmd): Add missing returns.

---
 ddb/db_break.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ddb/db_break.c b/ddb/db_break.c
index f45a1ca..bd31fa5 100644
--- a/ddb/db_break.c
+++ b/ddb/db_break.c
@@ -632,10 +632,12 @@ db_delete_cmd()
            if (db_read_token() != tNUMBER) {
                db_printf("Bad break point number #%s\n", db_tok_string);
                db_error(0);
+               return;
            }
            if ((tbp = db_find_breakpoint_number(db_tok_number, &bkpt)) == 0) {
                db_printf("No such break point #%d\n", db_tok_number);
                db_error(0);
+               return;
            }
            db_delete_breakpoint(bkpt->task, bkpt->address, tbp->tb_task_thd);
            return;
-- 
1.8.1.4


Reply via email to