On 20.11.2013 21:18:14, Guillem Jover wrote:
> On Wed, 2013-11-20 at 13:53:45 +0100, Marin Ramesa wrote:
> > * ddb/db_command.c [DB_MACHINE_COMMANDS]: Add comment after endif.
> > * i386/i386/setjmp.h (_longjmp): Comment out __volatile__.
>
> (This patch seems to mix two unrelated changes, at least from the
> patch description PoV.)
_longjmp is called from db_command.c. So while editing I noticed that
comments are missing. I was too lazy to make two patches.
> > diff --git a/i386/i386/setjmp.h b/i386/i386/setjmp.h
> > index 667eecf..08626e3 100644
> > --- a/i386/i386/setjmp.h
> > +++ b/i386/i386/setjmp.h
> > @@ -36,7 +36,7 @@ typedef struct jmp_buf {
> > extern int _setjmp(jmp_buf_t*);
> >
> > #ifdef __GNUC__
> > -extern __volatile__ void _longjmp(jmp_buf_t*, int);
> > +extern /*__volatile__*/ void _longjmp(jmp_buf_t*, int);
> > #endif
> >
> > #endif /* _I386_SETJMP_H_ */
>
> Why not just remove it?
Yes. It might be better to remove it. _longjmp is called only once.
