Marin Ramesa, le Tue 02 Jul 2013 11:41:55 +0200, a écrit :
> So, I made a preliminary patch with db_print.h. I don't really know if 
> this is an improvement over having extern statements in db_command.c. 

It is: by making the .c file (that defines the function) include the .h
file, it permits to make sure that both the caller and the callee do
really agree on the way the function is called.

>  extern void  db_listbreak_cmd();
>  extern void  db_listwatch_cmd();
> -extern void  db_show_regs(), db_show_one_thread(), db_show_one_task();
> +extern void  db_show_one_thread();
>  extern void  db_show_all_threads();

etc.  Ideally all these would go into common .h files.

Applied, thanks!

Samuel

Reply via email to