> First, my "usual" cleanup patch: > > * sysdeps/unix/sysv/linux/ldsodefs.h (VALID_ELF_OSABI) > (VALID_ELF_ABIVERSION, MORE_ELF_HEADER_DATA): Use ELFOSABI_GNU > instead of ELFOSABI_LINUX. > > ports/ChangeLog.arm > * sysdeps/unix/sysv/linux/arm/ldsodefs.h (VALID_ELF_OSABI) > (MORE_ELF_HEADER_DATA): Use ELFOSABI_GNU instead of ELFOSABI_LINUX. > > ports/ChangeLog.mips > * sysdeps/unix/sysv/linux/mips/ldsodefs.h (VALID_ELF_ABIVERSION): > Use ELFOSABI_GNU instead of ELFOSABI_LINUX.
This is fine. > I suggest we instead implement this in sysdeps/gnu/ldsodefs.h, as this is > a common GNU thing. That is a good thing to do. > Tested on x86 and x86_64 GNU/Linux, and x86 GNU/Hurd; glibc testsuite as > well as manually as follows: Verify on x86_64-linux-gnu that the change has no effect whatsoever on the compiled code. > * sysdeps/unix/sysv/linux/ldsodefs.h (VALID_ELF_HEADER) > (VALID_ELF_OSABI, VALID_ELF_ABIVERSION, MORE_ELF_HEADER_DATA): > Move macros to... > * sysdeps/gnu/ldsodefs.h: ... this new file. With that verified, this is fine. > +++ sysdeps/gnu/ldsodefs.h > @@ -0,0 +1,48 @@ > +/* Run-time dynamic linker data structures for loaded ELF shared objects. I'd use something actually describes this file. That's the description of sysdeps/generic/ldsodefs.h, really. Thanks, Roland
