Hi, On Mon, Apr 04, 2011 at 01:35:21PM +0100, Michael Walker wrote:
> The below patch fixes all compiler warnings. Nice :-) > It's quite long as I use a lot of warning flags (habit from when I was > working on my own kernel project): It would be best if you could split it up into a series of patches, each for one type of warning, along with an explanation... This would make reviewing much easier. (For me at least.) As these are only warning fixes, I guess it's not crucial though... > -CFLAGS = `pkg-config libxml-2.0 --cflags` -Wall -ggdb3 -O0 -std=c99 > -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE > -COMPILE=$(CC) $(CFLAGS) > +CFLAGS = `pkg-config libxml-2.0 --cflags` -ggdb3 -O0 -std=c99 > -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE > +WARN = -Wall -Wextra -Wshadow -Wpointer-arith -Wcast-align > -Wwrite-strings -Wmissing-declarations -Wredundant-decls > -Wnested-externs -Winline -Wno-long-long -Winit-self > -Wmissing-prototypes -Wstrict-prototypes -Wconversion -pedantic Using -std=c99 and -pedantic is not desirable: it will forbid GNU extensions (such as nested functions) -- but the Hurd code is not meant to be compiled with anything but GCC, so we don't care about portability at all! :-) > + Copyright (C) 2002, 2005 HurdFR. > + Written by Marc de Saint Sauveur <[email protected]> > + and Manuel Menal <[email protected]> Not really related to your patch -- but I wonder, did they really assign copyright to HurdFR? I kinda doubt that... As for the rest, Thomas analysed it in much more detail than I had the patience for :-) -antrik-
