Re: [PATCH 3/3] Use the new _hurd_exec_file_name function

[Carl Fredrik Hammar]

Hi,

On Mon, Jul 26, 2010 at 07:33:58PM +0200, Emilio Pozuelo Monfort wrote:
> >From c6276e2df1d370dbbdd7f4e6fb388f241f84fee7 Mon Sep 17 00:00:00 2001
> From: Emilio Pozuelo Monfort <poch...@gmail.com>
> Date: Wed, 26 May 2010 23:32:16 +0200
> Subject: [PATCH 3/3] Use the new _hurd_exec_file_name function
> 
> * configure.in: Check for _hurd_exec_file_name.
> * utils/fakeauth.c: Call _hurd_exec_file_name instead of
> _hurd_exec if it's available.
> * utils/rpctrace.c: Likewise.
> * utils/shd.c: Likewise.
> ---
>  configure.in     |    2 +-
>  utils/fakeauth.c |    9 +++++++--
>  utils/rpctrace.c |    6 +++++-
>  utils/shd.c      |    9 ++++++---
>  4 files changed, 19 insertions(+), 7 deletions(-)
> 
> diff --git a/configure.in b/configure.in
> index e8c1261..7eaf85b 100644
> --- a/configure.in
> +++ b/configure.in
> @@ -161,7 +161,7 @@ fi
>  AC_SUBST(VERSIONING)
>  
>  # Check if libc contains getgrouplist and/or uselocale.

This comment is slightly off now, change it to "Check if libc contains
these functions".

> -AC_CHECK_FUNCS(getgrouplist uselocale)
> +AC_CHECK_FUNCS(getgrouplist uselocale _hurd_exec_file_name)
>  
>  
> @@ -159,15 +159,18 @@ run (char **argv, int fd0, int fd1)
>             movefd (fd1, 1, &save1))
>           return -1;
>  
> +#ifdef HAVE__HURD_EXEC_FILE_NAME
> +       err = _hurd_exec_file_name (task, file, program, argv, environ);
> +#else
>         err = _hurd_exec (task, file, argv, environ);
> -
> +#endif
>         if (restorefd (fd0, 0, &save0) ||
>             restorefd (fd1, 1, &save1))
>           return -1;
>  
>         if (err)
>           {
> -           error (0, err, "_hurd_exec");
> +           error (0, err, "_hurd_exec_file_name");
>             err = task_terminate (task);

I guess it's overkill to wrap this in a #ifdef.  ;-)

Regards,
  Fredrik