Hi, On Tue, May 18, 2010 at 04:19:10PM +0200, Sergio Lopez wrote:
> This patch fixes external objects interface in mach_defpager (current > default pager in Hurd), so it can be used as backing store by other > translators (like tmpfs). I don't know enough about this code to actually understand the changes. However, on a quick glance, there seem to be several unrelated fixes in this patch?... Please split them into separate patches; and add a short explanation to each. > + /* FIXME: Currently, we're unable to free used swap space > + if (ds->dpager.size > ds->dpager.limit / vm_page_size) > + pager_truncate (&ds->dpager, ds->dpager.limit / vm_page_size); > + */ Don't comment out code -- use "#if 0" instead. -antrik-
