Follow-up Comment #2, bug #29655 (project hurd):
The patch looks good, but I do have two minor suggestions.
First, I found the comment a bit confusing. The "default" behavior is
determined by the O_NOLINK flag, and isn't something that is constant.
So perhaps you could change it to mention this, or better yet explain
the flags in terms of setting or clearing O_NOLINK.
Second, it is good that you check that both AT_SYMLINK_FOLLOW and
AT_SYMLINK_NOFOLLOW aren't set, but it is still possible to call `at`
functions with the wrong flag, e.g. `linkat(..., AT_SYMLINK_FOLLOW)`.
You could fix this by only allowing AT_SYMLINK_NOFOLLOW if O_NOLINK is
not set and AT_SYMLINK_FOLLOW if it is set.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?29655>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
