Hi, On Mon, Apr 12, 2010 at 09:11:52PM +0200, Patrik Olsson wrote: > On Sat, 2010-04-10 at 12:09 +0200, olafbuddenha...@gmx.net wrote: > > On Fri, Apr 09, 2010 at 11:42:25AM +0200, Patrik Olsson wrote:
> > > I have found one thing that seems incorrect in > > > hurd.git/hurd/password.defs. See the parameter/field "group" in > > > "password_check_group"? Shouldn't it be of type gid_t and not > > > uid_t? [...] > > Still, this probably should be fixed. How about a patch? :-) > > Well, if it ain't broken, then why fix it? :-) > > I think that going through all those folders to change the type will > take a whole day. It's not really easy to make a script for it either > since not all uid_t should be changed, only some. Besides, I cannot > check if the software will still build after the changes (or if it > will break other packages that assume the old type). Why can't you check it?... I agree though that it's probably not worth the trouble, considering that it's really just a formalism... I wonder whether it wouldn't be smarter just to abolish gid_t alltogether instead -- they are not likely to ever differ in technical terms, and there is probably no type checking worth talking of involved either... -antrik-
