Hello,
On Wed, May 27, 2009 at 11:04 PM, Thomas Schwinge <tschwi...@gnu.org> wrote:
> On Tue, May 26, 2009 at 11:31:52PM +0300, Sergiu Ivanov wrote:
>> diff --git a/netfs.c b/netfs.c
>> index 89d1bf6..7c375d2 100644
>> --- a/netfs.c
>> +++ b/netfs.c
>> @@ -71,9 +71,9 @@ netfs_append_args (char **argz, size_t *argz_len)
>> {
>> if (ulfs->path)
>> err = argz_add (argz, argz_len, ulfs->path);
>> - else
>> + /* else
>> err = argz_add (argz, argz_len,
>> - OPT_LONG (OPT_LONG_UNDERLYING));
>> + OPT_LONG (OPT_LONG_UNDERLYING));*/
>
> I suggest to not comment out code like this. It has problems with
> embedded comments, and probably other (stylistic) issues. If is is
> indeed temporary, then I suggest to use something like:
>
> #if 0
> /* Disabled because of X. */
>
> Or, as I guess in this case, if you'll never going to need this again for
> unionmount, then simply really remove the code. In case that you should
> later need to read it again, or in fact need to recover recover it, then
> there is git log -p, git revert, and friends.
Yeah, I was thinking of these comments today and came to the
conclusion that I should have removed the code rather than commenting
it out...
Thanks for pointing out.
Regards,
scolobb
