zhengda, le Thu 26 Jun 2008 19:31:12 +0200, a écrit : > >Hm... Something seems wrong with the indentation here -- but it looks as > >if it has been already wrong in the original code... Can you fix that > >please? > > > >Oh, and of course you still need a changelog entry. There is a section > >in the GCS on that as well... > > > Where should I write the changelog? in the patch?
Put it at the top of the patch yes. Make sure you have read the GNU documentation about ChangeLogs: they are meant to be a mere summary of what modifications the patch does, not of its goal. Read previous ChangeLog entries for samples. Samuel