[EMAIL PROTECTED] (Thomas Bushnell, BSG) writes: > Marco Gerards <[EMAIL PROTECTED]> writes: > >> In libnetfs/mutations.h the macro IO_SELECT_REPLY_PORT is not >> defined. That means that the netfs_S_io_select function does not get >> the reply port. >> >> If someone wants to override netfs_S_io_select, the function simply >> won't work correctly because the reply port is required. The patch >> for the console client I sent in yesterday overrides netfs_S_io_select >> so this change is required in order to make it work correctly. > > Be very careful in general with select on network thingies. This > doesn't apply to your use, but I want it on the record. To return > select true means that you can immediately do I/O with no waiting. > > That means that you certainly already have the data to read here on > the local computer, you cannot reliably expect to read something over > a network, ever.
Ok, I understand. Thanks a lot for your comments. I just assume that when overriding a function like io_select, you know what you are doing (like in my case). But I think because libnetfs can be (and is) used for more than networking alone this patch is useful (and even required for the console patch I sent in). Can I commit my patch, or can someone else please do that? Thanks, Marco _______________________________________________ Bug-hurd mailing list [EMAIL PROTECTED] http://lists.gnu.org/mailman/listinfo/bug-hurd
