> 2004-02-05 Gianluca Guida <[EMAIL PROTECTED]> ^ Two spaces. If in doubt, use GNU Emacs.
> > * linux/src/drivers/net/rtl8139.c: Added support for > DLink 528 TX and DLink 538 TX. Thanks for this. According to the GCS you will have to mention all changed, deleted and added functions, macros, etc. Something like: (PCI_VENDOR_ID_REALTEK): New macro. No, like this: ,---- | (PCI_VENDOR_ID_DLINK) [!PCI_VENDOR_ID_DLINK]: New macro. | (PCI_DEVICE_ID_DLINK_538TX) [!PCI_DEVICE_ID_DLINK_538TX]: New macro. `---- It is a conditional statment, and should be noted. For changed functions I would mention something like: (changedfunction): Check for the dlink PCIIDs. Maybe, Check for D-Link 538TX? And I would mention the source of this patch. Indeed... I doubt that any copyright issues will arise from it. The great nitpicker. _______________________________________________ Bug-hurd mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/bug-hurd