On Thu, Jan 29, 2004 at 06:41:20PM +0100, Marco Gerards wrote: > > Also put the code to change the LED for GNUMach into an #ifdef KDSETLEDS, > > so that compiles with old headers don't fail. > > I defined KDSETLED macro in pc_kbd.c (just like you did for the other > macros). This makes compiling independent of the the Mach version. > Just like this code works on every Mach version (I forgot to mention > that in my previous mail).
Ohhh, right, I forgot about that. We don't install that header :) That's ok then. BTW, the changelog entry has the dirname in it. For subdir changelogs this isn't needed. > So AFAIK I don't have to change anything here. > > > Second, you have your keyboard fix in this patch, so take care not to check > > it in accidentially. > > It is not accidental. I think this patch is more appropriate here. I > assume it can take a while before someone reads my autoconf related > patch while this small change is really small and can be checked in > some minutes. Then I think you lacked a changelog entry for it. I didn't check that part of the patch, check it in if you verified it - how does it come it doesn't allocate the keyboard buffer twice with your change? (Ie, you add an allocation at an earlier place, why isn't it allocated a second time in the place where it used to be allocated?) > > If you have done the above, you can check in the LED patches. > > Before doing that I will send the patch to bug-hurd first because both > Alfred and Roland asked me. Sure. Thanks, Marcus -- `Rhubarb is no Egyptian god.' GNU http://www.gnu.org [EMAIL PROTECTED] Marcus Brinkmann The Hurd http://www.gnu.org/software/hurd/ [EMAIL PROTECTED] http://www.marcus-brinkmann.de/ _______________________________________________ Bug-hurd mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/bug-hurd
