Re: fifo, mmap, errors [better patch]

[Greg Buchholz]

On Fri, 5 Sep 2003, Roland McGrath wrote:
> Actually I am favoring returning EOPNOTSUPP instead of ENODEV.  The ENODEV
> behavior is specific POSIXism for mmap, while EOPNOTSUPP is the generic
> Hurd protocol for any RPC that a server doesn't support.  I'm already
> putting in the libc change to have mmap translate to ENODEV.
>
> > Are there any patch submission guidlines?  (i.e. do we update the
> > ChangeLog for every trivial change?
>
> Yes.  Follow the coding conventions you see, and make a good log entry for
> each and every change.  No change ever goes in without a log entry.

        Alright, here's a better patch with ChangeLog entries and with the
return values changed to EOPNOTSUPP.


Greg Buchholz


diff -bBrw -U2 old/pfinet/ChangeLog hurd/pfinet/ChangeLog
--- old/pfinet/ChangeLog        Wed May  7 06:41:23 2003
+++ hurd/pfinet/ChangeLog       Fri Sep  5 17:01:27 2003
@@ -1,2 +1,6 @@
+2003-09-05  Greg Buchholz  <[EMAIL PROTECTED]>
+
+       * tunnel.c (trivfs_S_io_map): Changed return value to EOPNOTSUPP
+
 2003-05-07  Ognyan Kulev  <[EMAIL PROTECTED]>
 
diff -bBrw -U2 old/pfinet/tunnel.c hurd/pfinet/tunnel.c
--- old/pfinet/tunnel.c Thu Jun 13 13:59:14 2002
+++ hurd/pfinet/tunnel.c        Fri Sep  5 16:54:01 2003
@@ -627,10 +627,4 @@
                 mach_msg_type_name_t *wrtype)
 {
-  if (!cred)
     return EOPNOTSUPP;
-
-  if (cred->pi.class != tunnel_class)
-    return EOPNOTSUPP;
-
-  return EINVAL;
 }
diff -bBrw -U2 old/trans/ChangeLog hurd/trans/ChangeLog
--- old/trans/ChangeLog Wed Mar  5 18:24:58 2003
+++ hurd/trans/ChangeLog        Fri Sep  5 17:01:02 2003
@@ -1,2 +1,7 @@
+2003-09-05  Greg Buchholz <[EMAIL PROTECTED]>
+       
+       * fifo.c, new-fifo.c, null.c (trivfs_S_io_map): Change return value to 
+       EOPNOTSUPP (was EINVAL).
+
 2003-03-05  Roland McGrath  <[EMAIL PROTECTED]>
 
diff -bBrw -U2 old/trans/fifo.c hurd/trans/fifo.c
--- old/trans/fifo.c    Thu Jun 13 14:26:33 2002
+++ hurd/trans/fifo.c   Fri Sep  5 16:31:49 2003
@@ -325,5 +325,5 @@
                 mach_msg_type_name_t *wrtype)
 {
-  return EINVAL;
+  return EOPNOTSUPP;
 }
 
diff -bBrw -U2 old/trans/new-fifo.c hurd/trans/new-fifo.c
--- old/trans/new-fifo.c        Thu Jun 13 14:26:42 2002
+++ hurd/trans/new-fifo.c       Fri Sep  5 16:32:14 2003
@@ -510,5 +510,5 @@
                 mach_msg_type_name_t *wrtype)
 {
-  return EINVAL;
+  return EOPNOTSUPP;
 }
 
diff -bBrw -U2 old/trans/null.c hurd/trans/null.c
--- old/trans/null.c    Thu Jun 13 14:26:30 2002
+++ hurd/trans/null.c   Fri Sep  5 16:32:51 2003
@@ -131,5 +131,5 @@
                 mach_msg_type_name_t *wrtype)
 {
-  return EINVAL;               /* XXX should work! */
+  return EOPNOTSUPP;           /* XXX should work! */
 }
 

_______________________________________________
Bug-hurd mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/bug-hurd