--- Neal H Walfield <[EMAIL PROTECTED]> wrote: > > Hey, > > > > Guess what? It's time for my weekly patch ;) This stuff is > mostly > > out of the glibc manual ;) > > > > 2002-03-03 James A. Morrison <[EMAIL PROTECTED]> > > > > * mux.c (lookup_host): removed arbitrary limit on host name > > size. > > This is a good start. > > Perhaps we should have a function in libshouldbeinlibc that does > this. > ftpfs and ping also need to be fixed. > > Consider using realloc instead of a free followed by a malloc. >
Ok, I've done this in my version, it saves a few lines. Any ideas as to what you would call these functions in libshouldbeinlibc ? Perhaps gethostbyname_a for alloc? > Please conform more closely to the GNU coding standards. For > instance, you cast too much (no need to cast the return result of > malloc; in fact it is wrong), parentheses are wrong, some > indentation > and spacing also look incorrect. > Humm, I do cast the return value of malloc, but any of the examples in the libc manual or the GCS also cast the return value of malloc The GCS only says not to cast to void * . I will beat it into my brain to run my code through indent on of these days. I'm not sure what you mean by the parentheses are wrong. I have added spaces before parentheses if that is what you meant. I've also, hopefully, fixed the style in my multiple firmlink patch, so I'll mail those patches in next weekend. ===== James Morrison University of Waterloo Computer Science - Digital Hardware 2A co-op http://hurd.dyndns.org Anyone refering this as 'Open Source' shall be eaten by a GNU __________________________________________________ Do You Yahoo!? Yahoo! Sports - sign up for Fantasy Baseball http://sports.yahoo.com _______________________________________________ Bug-hurd mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/bug-hurd
