James Morrison <[EMAIL PROTECTED]> writes: > - err = __dir_mkfile (dir, O_WRONLY, 0644, &new); > + err = __dir_mkfile (dir, O_CREAT|O_WRITE, 0644, &new);
Hrm. O_WRITE is surely better than O_WRONLY, but they are equal in fact. And the implementation of dir-mkfile.c in libdiskfs always turns on O_READ, O_WRITE, and O_EXEC anyway, regardless of what you asked for. I'm not sure why it does this (is it really the right Posix semantics??). O_CREAT is entirely ignored here. The flags are used only to initialize the peropen for the returned port. So if this fixes anything, I'm entirely mystified why. I'd rather not see the change checked in without understanding it. Thomas _______________________________________________ Bug-hurd mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/bug-hurd
