Re: mach_host_self() doesn't acquire new port name?!

[Thomas Bushnell, BSG]

Marcus Brinkmann <[EMAIL PROTECTED]> writes:

> While I am looking at stupid little omissions that don't make a real
> difference: In proc/host.c we call host_kernel_version and use the result
> without making sure it is actually null terminated. The kernel uses strncpy
> to copy out the string.  Should the kernel put
> 
> out_version[MAX_KERNEL_VERSION - 1] = '\0';
> 
> or should proc do this, or should proc allocated MAX_KERNEL_VERSION + 1 and
> set kv[KERNEL_VERSION_MAX] to '\0', to save the last character?

Blech.

We should assume that Mach defines the interface, and change proc to
adapt.  That will keep our interfaces as similar to other Mach's as
possible.

Even though, in this case, the kernel has the wrong interface
specification.  (It's also wrong in just the same way gethostname is
wrong.)


_______________________________________________
Bug-hurd mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/bug-hurd